This page is a snapshot from the LWG issues list, see the Library Active Issues List for more information and the meaning of New status.

4151. Precondition of inplace_vector::swap

Section: 23.3.16.5 [inplace.vector.modifiers] Status: New Submitter: Arthur O'Dwyer Opened: 2024-09-07 Last modified: 2024-09-18

Priority: 2

View all issues with New status.

Discussion:

Right now inplace_vector::swap has only a declaration in the class synopsis; it doesn't specify what the behavior of swap for inplace_vectors actually is. So I think the behavior ends up being governed by 23.2.2.2 [container.reqmts], which are written from the point of view of a container that manages an external heap allocation so that swapping containers doesn't touch the elements at all, just changes their ownership.

inplace_vector::swap actually works more like array::swap, which has its own specification in 23.3.3.3 [array.members], where it is defined in terms of std::swap_ranges. The std::swap_ranges algorithm (26.7.3 [alg.swap]) has a precondition! This precondition is missing from inplace_vector::swap.

That is, I think we currently have no wording that explains why

std::pmr::monotonic_buffer_resource mr1;
std::inplace_vector<std::pmr::vector<int>, 2> v1, v2;
v1.emplace_back(1, &mr1);
v2.emplace_back(1);
v1.swap(v2);

is undefined behavior. The current spec seems to say this Just Works, even though it physically cannot work because v1[0] and v2[0] don't dynamically meet the semantic requirements of being "swappable with" each other, and v1.swap(v2) is necessarily going to try to swap them.

[2024-09-18; Reflector poll]

Set priority to 2 after reflector poll. The Preconditions: (but not the Effects:) would be changed again if P3160R2 is approved.

Proposed resolution:

This wording is relative to N4988.

1. Modify 23.3.16.5 [inplace.vector.modifiers] as indicated:

   [Drafting note: It is suggested to add the new wording to the end of the existing subclause]

   constexpr void swap(inplace_vector& x) noexcept(N == 0 ||
     (is_nothrow_swappable_v<T> && is_nothrow_move_constructible_v<T>));
   

   -?- Preconditions: Let M be min(size(), x.size()). For each non-negative integer n < M, (*this)[n] is swappable with (16.4.4.3 [swappable.requirements]) x[n].

   -?- Effects: Exchanges the contents of *this and x.