2813. std::function should not return dangling references

Section: 23.14.13.2.1 [func.wrap.func.con] Status: Open Submitter: Brian Bi Opened: 2016-11-03 Last modified: 2017-07-16

Priority: 2

View other active issues in [func.wrap.func.con].

View all other issues in [func.wrap.func.con].

View all issues with Open status.

Discussion:

If a std::function has a reference as a return type, and that reference binds to a prvalue returned by the callable that it wraps, then the reference is always dangling. Because any use of such a reference results in undefined behaviour, the std::function should not be allowed to be initialized with such a callable. Instead, the program should be ill-formed.

A minimal example of well-formed code under the current standard that exhibits this issue:

#include <functional>

int main() 
{
  std::function<const int&()> F([]{ return 42; });
  int x = F(); // oops!
}

[2016-11-22, David Krauss comments and suggests wording]

Indirect bindings may also introduce temporaries inside std::function, e.g.:

void f(std::function<long const&()>); // Retains an observer to a long.

void g() {
  int v;
  f([&]()->int& { return v; } ); // int lvalue binds to long const& through a temporary.
}

A fix has been implemented. Conversions that may be conversion operators are allowed, though, because those can produce legitimate glvalues. Before adopting this, it need to be considered considered whether there should be SFINAE or a hard error.

[Issues Telecon 16-Dec-2016]

Priority 2

[2016-07, Toronto Saturday afternoon issues processing]

Billy to work with Brian to rework PR. Status to Open

Proposed resolution:

This wording is relative to N4618.

  1. Add a second paragraph to the remarks section of 23.14.13.2.1 [func.wrap.func.con]:

    template<class F> function(F f);
    

    -7- Requires: F shall be CopyConstructible.

    -8- Remarks: This constructor template shall not participate in overload resolution unless

    • F is Lvalue-Callable (23.14.13.2 [func.wrap.func]) for argument types ArgTypes... and return type R, and

    • If R is type "reference to T" and INVOKE(ArgTypes...) has value category V and type U:

      • V is a prvalue, U is a class type, and T is not reference-related (11.6.3 [dcl.init.ref]) to U, and

      • V is an lvalue or xvalue, and either U is a class type or T is reference-related to U.

    […]