272. Missing parentheses around subexpression

Section: 30.5.5.4 [iostate.flags] Status: CD1 Submitter: Martin Sebor Opened: 2000-11-02 Last modified: 2016-02-10

Priority: Not Prioritized

View all other issues in [iostate.flags].

View all issues with CD1 status.

Duplicate of: 569

Discussion:

27.4.4.3, p4 says about the postcondition of the function: If rdbuf()!=0 then state == rdstate(); otherwise rdstate()==state|ios_base::badbit.

The expression on the right-hand-side of the operator==() needs to be parenthesized in order for the whole expression to ever evaluate to anything but non-zero.

Proposed resolution:

Add parentheses like so: rdstate()==(state|ios_base::badbit).